search

lambda-llama / bitset

A compact functional set data structure
http://hackage.haskell.org/package/bitset
MIT License
13 stars 13 forks source link

General improvements #18

Closed treeowl closed 8 years ago

treeowl commented 8 years ago
superbobry commented 8 years ago

This looks very good! Could you amend/push it once again to make Travis build the PR?

treeowl commented 8 years ago

@superbobry, I used the latest multi-GHC Travis config with the defaults. It's possible that some changes are needed to get the configuration you wanted. The old thing looked pretty old.

treeowl commented 8 years ago

Hmmm... It looks like there's an issue open regarding recent GHC; I'll probably have to re-restrict the version bounds, but I want to see how the tests fall first.

treeowl commented 8 years ago

I went too far trying to update .travis.yml. I've reverted that bit. I think everything else is sane. The Travis stuff will have to wait for a later PR. There are some majorly unpleasant problems relating to https://github.com/bos/aeson/pull/426, it seems.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.6%) to 87.719% when pulling 45282d264eb4b1e149df4a8d8757722c6a685de0 on treeowl:general-update into bf7032665bda31e63408d63a137229609a919268 on lambda-llama:master.

treeowl commented 8 years ago

@superbobry, it appears that the remaining test failures are caused by bit rot and are not my fault. I believe this should be ready to merge if you like it.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.6%) to 87.719% when pulling be7f96624a49f5e8b180f13d84bedef85f8eda2b on treeowl:general-update into bf7032665bda31e63408d63a137229609a919268 on lambda-llama:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.6%) to 87.719% when pulling 3bdd6ca535a6cead27d86f1fbdfd361954c9c9e8 on treeowl:general-update into bf7032665bda31e63408d63a137229609a919268 on lambda-llama:master.

treeowl commented 8 years ago

Hrmm... Need to improve one test, actually.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.6%) to 87.719% when pulling f85d281dbcd950a124a8cd518085ce9b4ff7dc40 on treeowl:general-update into bf7032665bda31e63408d63a137229609a919268 on lambda-llama:master.

treeowl commented 8 years ago

Yeah, that should do it.

treeowl commented 8 years ago

@superbobry, once this is merged, I have a nice juicy bag of list fusion stuff for you.

superbobry commented 8 years ago

Thank you very much!

treeowl commented 8 years ago

And thank you! I may come up with a solution that covers the signed case nicely as well, but right now I'm bashing my head against Data.Sequence.fromList with Lennart Spitzner, trying to get more of the intermediate representation into the call stack. On Jun 15, 2016 2:44 PM, "Sergei Lebedev" notifications@github.com wrote:

Thank you very much!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lambda-llama/bitset/pull/18#issuecomment-226281861, or mute the thread https://github.com/notifications/unsubscribe/ABzi_YL8PBZUiz9Fw6sIOCJMYoEzJlGFks5qMEf0gaJpZM4IxcpU .