search

lambda-nvda / lambdaNvda

NVDA Add-On for LAMBDA Software
GNU General Public License v2.0
5 stars 4 forks source link

remove lambda braille table entry in GUI #12

Closed albzan closed 8 years ago

albzan commented 8 years ago
nvdaes commented 8 years ago

Sorry, I have mada a stupid mistake and reopened this fixed issue. Thanks, great work.

El 13/09/2016 a las 6:20, nvdaes escribió:

Reopened #12 https://github.com/nvdaaddons/lambda/issues/12.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvdaaddons/lambda/issues/12#event-786994088, or mute the thread https://github.com/notifications/unsubscribe-auth/APE65DjWfCzJcN3HKRZKCQMKUqS_hGW-ks5qpiSOgaJpZM4J6Ukz.

nvdaes commented 8 years ago

Hi, unfortunately, adding a table named lambda-es.utb, this is not deleted. Thanks.

albzan commented 8 years ago

Confirmed

nvdaes commented 8 years ago

Anyway, I think that tables should have translatable strings to be displayed.

I think it's better that you do changes and not reviewers.

Anyway, sometimes reviewers create for instance a branch named possibleImprovements for reviewed add-ons, and then authors can evaluate it and merge changes or consider them, since sometimes it can be easy to understand suggestions.

Just is a proposal, since sometimes it can be fast to think in action.

Thanks.

El 13/09/2016 a las 9:23, albzan escribió:

Confirmed

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/nvdaaddons/lambda/issues/12#issuecomment-246597277, or mute the thread https://github.com/notifications/unsubscribe-auth/APE65MdNiK7G3iItLYHHfkPt-nP4k8Suks5qpk9tgaJpZM4J6Ukz.

nvdaes commented 8 years ago

Thanks. I will review this.

El 13/09/2016 a las 9:37, albzan escribió:

Closed #12 https://github.com/nvdaaddons/lambda/issues/12 via e30977b https://github.com/nvdaaddons/lambda/commit/e30977b512e0633bb8409e96e1d28131a7ae8167.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/nvdaaddons/lambda/issues/12#event-787148056, or mute the thread https://github.com/notifications/unsubscribe-auth/APE65PxIrdhjTxgkTPD3oJfn7Sw6tx5Rks5qplKogaJpZM4J6Ukz.