Closed ivnc closed 6 years ago
Now guiHelper is used. Please review it again. What do you suggest to include in documentation? Changelog usually isn't updated until a stable release preparation.
Regards.
I approved changes since comments are related just to style, not functionality:
Generally, sHelper instead of helper is used, but this is optional.
-1 argument can be removed in the static text control, and wx.ID_ANY is not needed for checkboxes using guiHelper. See the Document formatting dialog in NVDA for an example.
About documentation, I suggest something like:
Compatible with NVDA 2018.3 and later.
Thanks
I implemented your suggestions, so I think we can merge now. Regarding the update of the changelog I think that we can do it when preparing 1.2.2 stable, and anyway directly to master.
Regards.
By the way, thanks for your comments. I'm new to coding and any help is always appreciated.
Regards.
OK, if you need access to addonFiles to update get.php let me know. Joseph and me are admins of addonFiles repo. Or I can modify get.php, but perhaps it's better that people can write to the repo to work faster and we can do other things too.
I think I already have write access to addonFiles. Anyway I'll check and let you know if not.
Thanks. Regards.
Yes, I remember I gave access to you, but in case this was lost or something, since a person removed it and then access for people could suffer changes, and I'm not sure when this happened.
In order to improve compatibility with WXPython 4, deprecated wx.NewId() has been changed to wx.ID_ANY on lambdaSetupProfile, as IDs are not relevant in this case. In addition, the version in buildVars was updated from 1.2.1A to 1.2.2-dev.
If any problem please comment.