search

lambda-nvda / lambdaNvda

NVDA Add-On for LAMBDA Software
GNU General Public License v2.0
5 stars 4 forks source link

Python 3 compatibility #55

Closed ivnc closed 4 years ago

ivnc commented 5 years ago

Changes made

Testing performed

  1. With NVDA 2019.2RC2: no issues were detected.
  2. With NVDA alpha 18330,b4db7dca: no issues were detected.

Testing environment

Addon package to test (change .zip by .nvda-addon, uploading addon packages is not allowed by GitHub): lambda-1.2.3-dev.zip

Please test and comment with your results.

ivnc commented 5 years ago

Possible compatibility issue in lambdaEdit, line 33: if EditableTextDisplayModelTextInfo._storyFieldsAndRects[1] contains something different from floats, it may be required to ensure that the value of LambdaEditorFlatTextInfo.rects is int, as Python 3 as changed the effects of / operator. CC @albzan

albzan commented 5 years ago

Hello Iván,

Maybe there is also something with if statements that I have to check. I'll see in the next weeks and I'll help on compatibility with Py3.

Cheers,

Alberto

Il giorno ven 9 ago 2019 alle ore 19:50 Iván Novegil < notifications@github.com> ha scritto:

Possible compatibility issue in lambdaEdit, line 33: if EditableTextDisplayModelTextInfo._storyFieldsAndRects[1] contains something different from floats, it may be required to ensure that the value of LambdaEditorFlatTextInfo.rects is int, as Python 3 as changed the effects of / operator. CC @albzan https://github.com/albzan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lambda-nvda/lambdaNvda/pull/55?email_source=notifications&email_token=AD42C54G5D2UJYGAAHCENATQDWU7JA5CNFSM4IKL7MSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37K62Q#issuecomment-520007530, or mute the thread https://github.com/notifications/unsubscribe-auth/AD42C52BPQXBQRXQRLSFWQTQDWU7JANCNFSM4IKL7MSA .

ivnc commented 4 years ago

Is this PR ready to merge? The transition to Python 3 in NVDA is at the final phase...

Regards.

albzan commented 4 years ago

Hi All, Thank you @ivnc for your help. Yes, I have to look into this and I'll check for this. For the "stable" tag, we can delete it, we should keep the "latest" tag I use the "latest" to have a unique url that redirect to the latest version. This url has been shared before the addon was in the official Add-Ons pages, and so a few sites have this, like here: http://vediamoinsieme.altervista.org/lambda-con-nvda-addon/

Alberto

ivnc commented 4 years ago

According to my tests the migrated version seems to be OK. Is it strictly necessary to break compatibility with Py2?

Regards.

albzan commented 4 years ago

Theoretically no, can you do a test with 2.x? I'm in train right now and I can't do. Thanks Alberto

Il giorno gio 13 feb 2020 alle ore 13:49 Iván Novegil < notifications@github.com> ha scritto:

According to my tests the migratied version seems to be OK. Is it strictly necessary to break compatibility with Py2?

Regards.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lambda-nvda/lambdaNvda/pull/55?email_source=notifications&email_token=AD42C53CN27VCYFUCHO2OOTRCU6UNA5CNFSM4IKL7MSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELU2XQY#issuecomment-585739203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD42C56HZWVZHXHSW3372LLRCU6UNANCNFSM4IKL7MSA .

ivnc commented 4 years ago

In my comment I was making reference to the code, but in fact the latest code seems to be compatible with NVDA 2019.2.1 as well. Pleas test by your own to confirm this. As it looks like no more code changes are needed, let's merge.

Regards.