lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.

https://lambdaclass.github.io/cairo-vm

Apache License 2.0

509 stars 142 forks source link

small fix to cancel duplicate workflow file #1497

Closed greged93 closed 9 months ago

greged93 commented 9 months ago

Fix workflow error

Description

Fixes a small issue in the cancel-duplicate workflow file. The cancellation of the bench workflow is not needed for bench_pull_request anymore since this was removed. Not sure if you want to add the hyperfine workflow to it, let me know.

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.
- [ ] Documentation has been added/updated.
- [x] CHANGELOG has been updated.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8887e60) 96.82% compared to head (b544c5e) 96.82%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1497 +/- ## ======================================= Coverage 96.82% 96.82% ======================================= Files 96 96 Lines 39684 39684 ======================================= Hits 38423 38423 Misses 1261 1261 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Oppen commented 9 months ago

I seem to recall this workaround is not even needed anymore: I believe concurrency is meant to handle cancellation these days.

greged93 commented 9 months ago

ah true, I can just remove it then.

Oppen commented 9 months ago

We would need to check the concurrency settings in the other workflows before removing the whole cancel workflow.

greged93 commented 9 months ago

so right now, this workflow was cancelling the runs for rust and bench_pull_request workflows in case of duplicates. bench_pull_request was removed, I can add concurrency settings to the rust workflow. Would that work?

Oppen commented 9 months ago

I think that would work, yes.