search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
517 stars 148 forks source link

Add option to pass Sierra programs to cairo1-run #1544

Closed Vid201 closed 6 months ago

Vid201 commented 10 months ago

TITLE

Description

This PR adds support to pass Sierra programs directly to cairo1-run. Useful in cases when you already have Sierra representations.

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.64%. Comparing base (6ff8126) to head (7fdd8da).

:exclamation: Current head 7fdd8da differs from pull request most recent head ec9dbfa. Consider uploading reports for the commit ec9dbfa to get more accurate results

Files Patch % Lines
cairo1-run/src/main.rs 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1544 +/- ## ========================================== + Coverage 94.90% 97.64% +2.74% ========================================== Files 98 92 -6 Lines 38102 37622 -480 ========================================== + Hits 36160 36737 +577 + Misses 1942 885 -1057 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Oppen commented 10 months ago

I see the linter fails due to an unnecessary binding. The comment I left before should fix it (it's the same place). Also, we'll need an updated changelog. The Hyperfine workflow failure is expected, it can't post the comment due to credential issues for PRs from external contributors.

Please fix the changelog and the lint and I think it's good to go.

Vid201 commented 10 months ago

I see the linter fails due to an unnecessary binding. The comment I left before should fix it (it's the same place). Also, we'll need an updated changelog. The Hyperfine workflow failure is expected, it can't post the comment due to credential issues for PRs from external contributors.

Please fix the changelog and the lint and I think it's good to go.

Updated, tnx for review

Oppen commented 6 months ago

1719 got merged instead. @fmoletta, don't forget to add a coauthored-by or some other form of credit the next time 🙈

Reference for the PR on its own doesn't give credit to the original author.