search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
517 stars 148 forks source link

Bump rust version to 1.72 #1547

Closed fmoletta closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b020f11) 97.21% compared to head (e2f18a2) 97.78%.

:exclamation: Current head e2f18a2 differs from pull request most recent head f62b4b8. Consider uploading reports for the commit f62b4b8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1547 +/- ## ========================================== + Coverage 97.21% 97.78% +0.57% ========================================== Files 90 89 -1 Lines 36454 36451 -3 ========================================== + Hits 35439 35645 +206 + Misses 1015 806 -209 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.182 ± 0.019 2.164 2.222 1.00
head big_factorial 2.308 ± 0.062 2.261 2.464 1.06 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.155 ± 0.024 2.123 2.185 1.00
head big_fibonacci 2.291 ± 0.041 2.225 2.345 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.889 ± 0.057 7.828 7.976 1.00
head blake2s_integration_benchmark 8.598 ± 0.240 8.450 9.210 1.09 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.236 ± 0.016 2.217 2.267 1.00
head compare_arrays_200000 2.367 ± 0.038 2.326 2.424 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.424 ± 0.009 1.416 1.448 1.00
head dict_integration_benchmark 1.491 ± 0.014 1.466 1.506 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.264 ± 0.022 1.246 1.321 1.00
head field_arithmetic_get_square_benchmark 1.416 ± 0.024 1.383 1.456 1.12 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.969 ± 0.047 7.901 8.036 1.00
head integration_builtins 8.597 ± 0.144 8.443 8.790 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.215 ± 0.060 8.143 8.320 1.00
head keccak_integration_benchmark 8.841 ± 0.144 8.672 9.026 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.260 ± 0.016 2.247 2.289 1.00
head linear_search 2.396 ± 0.032 2.353 2.430 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.555 ± 0.013 1.545 1.581 1.00
head math_cmp_and_pow_integration_benchmark 1.849 ± 0.022 1.821 1.879 1.19 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.403 ± 0.011 1.389 1.426 1.00
head math_integration_benchmark 1.629 ± 0.018 1.610 1.656 1.16 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.236 ± 0.013 1.224 1.268 1.00
head memory_integration_benchmark 1.240 ± 0.017 1.220 1.261 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.585 ± 0.008 1.577 1.601 1.00
head operations_with_data_structures_benchmarks 1.947 ± 0.037 1.916 2.041 1.23 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 600.1 ± 3.2 596.0 605.0 1.00
head pedersen 603.5 ± 3.5 597.7 606.6 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.063 ± 0.004 1.059 1.074 1.05 ± 0.01
head poseidon_integration_benchmark 1.009 ± 0.003 1.001 1.013 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.897 ± 0.003 1.891 1.902 1.00
head secp_integration_benchmark 1.982 ± 0.028 1.943 2.027 1.04 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 766.0 ± 1.7 762.7 768.3 1.00
head set_integration_benchmark 769.7 ± 7.8 758.3 786.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.415 ± 0.020 4.386 4.455 1.00
head uint256_integration_benchmark 4.802 ± 0.049 4.668 4.848 1.09 ± 0.01
Oppen commented 10 months ago

There seems to be a notorious slowdown for some benchmarks.