search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
509 stars 142 forks source link

Create proof_programs symbolic links in `deps` target #1556

Closed fmoletta closed 7 months ago

fmoletta commented 8 months ago

Implements solution proposed in https://github.com/lambdaclass/cairo-vm/pull/1555#pullrequestreview-1813477975 Adds a makefile target to create symbolic links to cairo programs under proof_programs subdirectory Removes symbolic links from repo

github-actions[bot] commented 8 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.268 ± 0.020 2.252 2.320 1.00
head big_factorial 2.279 ± 0.024 2.252 2.323 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.242 ± 0.012 2.226 2.262 1.00
head big_fibonacci 2.249 ± 0.009 2.236 2.262 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.257 ± 0.071 8.177 8.363 1.00 ± 0.01
head blake2s_integration_benchmark 8.257 ± 0.060 8.180 8.343 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.289 ± 0.011 2.276 2.312 1.00
head compare_arrays_200000 2.307 ± 0.020 2.282 2.355 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.453 ± 0.013 1.445 1.488 1.00 ± 0.01
head dict_integration_benchmark 1.450 ± 0.007 1.441 1.459 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.287 ± 0.005 1.281 1.294 1.00
head field_arithmetic_get_square_benchmark 1.295 ± 0.006 1.289 1.304 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.271 ± 0.057 8.217 8.365 1.00
head integration_builtins 8.295 ± 0.056 8.221 8.399 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.546 ± 0.048 8.488 8.617 1.00 ± 0.01
head keccak_integration_benchmark 8.536 ± 0.048 8.493 8.620 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.340 ± 0.007 2.332 2.354 1.00
head linear_search 2.354 ± 0.016 2.333 2.387 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.576 ± 0.005 1.566 1.583 1.00
head math_cmp_and_pow_integration_benchmark 1.582 ± 0.005 1.574 1.588 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.446 ± 0.006 1.437 1.452 1.00 ± 0.01
head math_integration_benchmark 1.445 ± 0.005 1.437 1.452 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.264 ± 0.004 1.260 1.270 1.00
head memory_integration_benchmark 1.267 ± 0.004 1.261 1.273 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.608 ± 0.005 1.602 1.616 1.00
head operations_with_data_structures_benchmarks 1.620 ± 0.010 1.610 1.640 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 606.1 ± 1.4 603.5 608.2 1.00
head pedersen 607.3 ± 2.8 604.8 612.8 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.058 ± 0.007 1.050 1.073 1.00
head poseidon_integration_benchmark 1.061 ± 0.005 1.053 1.067 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.929 ± 0.011 1.918 1.959 1.00
head secp_integration_benchmark 1.930 ± 0.011 1.923 1.954 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 753.6 ± 1.6 750.7 756.0 1.00
head set_integration_benchmark 753.7 ± 0.7 752.7 754.8 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.557 ± 0.028 4.526 4.614 1.00
head uint256_integration_benchmark 4.594 ± 0.075 4.547 4.799 1.01 ± 0.02
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dea2723) 97.13% compared to head (2217316) 97.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1556 +/- ## ======================================= Coverage 97.13% 97.13% ======================================= Files 91 91 Lines 37263 37263 ======================================= Hits 36196 36196 Misses 1067 1067 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.