lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
508 stars 142 forks source link

refactor: Remove memory_holes checks for tests in cairo_run_tests.rs #1584

Closed fmoletta closed 7 months ago

fmoletta commented 8 months ago

Most of the integration tests in cairo_run_tests.rs also check that the amount of memory holes after the vm run is equal to the ones counted when running with the python VM, however this is not such a robust solution as the values are hardcoded and may be wrong (as evidenced by #1583). Once #1578 is merged, we will be able to truly check that the memory holes are not miscounted by comparing Cairo PIE outputs against the python vm, removing the need for these specific checks that may be unreliable.