lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
508 stars 142 forks source link

Remove underscore prefix from test file names #1588

Closed fmoletta closed 7 months ago

fmoletta commented 8 months ago

Rename _keccak.cairo -> keccak.cairo Rename _keccak_alternative_hint.cairo -> _keccak_alternative_hint.cairo

github-actions[bot] commented 8 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.277 ± 0.024 2.257 2.340 1.00
head big_factorial 2.285 ± 0.016 2.267 2.307 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.230 ± 0.012 2.218 2.252 1.00
head big_fibonacci 2.237 ± 0.005 2.230 2.248 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.181 ± 0.037 8.120 8.234 1.00
head blake2s_integration_benchmark 8.251 ± 0.206 8.121 8.817 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.293 ± 0.019 2.271 2.319 1.00
head compare_arrays_200000 2.340 ± 0.057 2.298 2.495 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.446 ± 0.014 1.434 1.481 1.00
head dict_integration_benchmark 1.475 ± 0.025 1.456 1.536 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.296 ± 0.015 1.280 1.322 1.00
head field_arithmetic_get_square_benchmark 1.303 ± 0.006 1.295 1.315 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.237 ± 0.080 8.166 8.393 1.00
head integration_builtins 8.300 ± 0.088 8.195 8.444 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.465 ± 0.079 8.372 8.557 1.00
head keccak_integration_benchmark 8.465 ± 0.092 8.378 8.635 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.335 ± 0.057 2.297 2.484 1.00 ± 0.03
head linear_search 2.328 ± 0.015 2.313 2.356 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.574 ± 0.005 1.566 1.586 1.00
head math_cmp_and_pow_integration_benchmark 1.601 ± 0.005 1.597 1.611 1.02 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.443 ± 0.006 1.436 1.456 1.00
head math_integration_benchmark 1.473 ± 0.010 1.461 1.494 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.260 ± 0.012 1.251 1.288 1.00
head memory_integration_benchmark 1.264 ± 0.012 1.255 1.292 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.624 ± 0.011 1.614 1.649 1.00
head operations_with_data_structures_benchmarks 1.653 ± 0.008 1.643 1.665 1.02 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 607.0 ± 5.9 601.3 622.3 1.00 ± 0.01
head pedersen 606.5 ± 6.6 602.4 624.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.059 ± 0.006 1.053 1.069 1.00 ± 0.01
head poseidon_integration_benchmark 1.059 ± 0.005 1.052 1.067 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.927 ± 0.008 1.918 1.939 1.00
head secp_integration_benchmark 1.944 ± 0.009 1.935 1.966 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 770.9 ± 1.7 768.8 773.5 1.00
head set_integration_benchmark 773.4 ± 2.0 770.6 776.3 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.551 ± 0.045 4.494 4.611 1.00
head uint256_integration_benchmark 4.583 ± 0.038 4.550 4.640 1.01 ± 0.01
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3b5be72) 97.14% compared to head (a9c8e84) 97.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1588 +/- ## ======================================= Coverage 97.14% 97.14% ======================================= Files 91 91 Lines 37185 37185 ======================================= Hits 36124 36124 Misses 1061 1061 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.