search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
508 stars 142 forks source link

Feature: deserialize AIR private input #1589

Closed odesenfans closed 6 months ago

odesenfans commented 7 months ago

Added an implementation of From<AirPrivateInputSerializable> for AirPrivateInput, making it easier to interact with already generated private inputs.

Checklist

odesenfans commented 7 months ago

On a related topic, I do think it would make sense to have AirPrivateInput to be a struct instead of a hashmap as it would make it easier to use. AirPrivateInputSerializable could then contain an AirPrivateInput field (+ serde(flatten)).

Any thoughts?

odesenfans commented 7 months ago

Added a unit test and rebased.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0e6a235) 97.66% compared to head (5830048) 97.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1589 +/- ## ======================================= Coverage 97.66% 97.67% ======================================= Files 91 91 Lines 37318 37393 +75 ======================================= + Hits 36448 36523 +75 Misses 870 870 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pefontana commented 7 months ago

@odesenfans Here too, just merge conflicts and we will merge it!

pefontana commented 6 months ago

@odesenfans were you able to merge main?

odesenfans commented 6 months ago

Hey @pefontana , sorry I was busy with something else. I just rebased the branch.