search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
504 stars 138 forks source link

Use locked dependencies to install `cargo-nextest` & `wasm-pack` #1614

Closed fmoletta closed 6 months ago

fmoletta commented 6 months ago

Installation of cargo-nextest is currently failing (both locally & in the fresh-run CI workflow) as one of it's dependencies has been updated to no longer be compatible with rust version lower than 1.74. This PR solves this issue by passing the --locked flag when installing cargo-nextest in order to force the versions in the Cargo.lock to be used, with an older version of the dependency that is compatible with rust 1.70. This is also the case for wasm-pack. Closes #1613 Closes #1612

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (28e055e) 97.16% compared to head (7125eff) 97.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1614 +/- ## ======================================= Coverage 97.16% 97.16% ======================================= Files 92 92 Lines 37369 37369 ======================================= Hits 36309 36309 Misses 1060 1060 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.266 ± 0.014 2.252 2.292 1.00
head big_factorial 2.269 ± 0.019 2.247 2.304 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.261 ± 0.017 2.238 2.285 1.00 ± 0.01
head big_fibonacci 2.259 ± 0.024 2.240 2.315 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.242 ± 0.080 8.165 8.386 1.00 ± 0.01
head blake2s_integration_benchmark 8.220 ± 0.060 8.172 8.380 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.311 ± 0.048 2.283 2.444 1.01 ± 0.02
head compare_arrays_200000 2.292 ± 0.006 2.284 2.303 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.461 ± 0.016 1.445 1.499 1.01 ± 0.01
head dict_integration_benchmark 1.452 ± 0.013 1.437 1.482 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.290 ± 0.009 1.280 1.307 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.283 ± 0.005 1.275 1.291 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.275 ± 0.072 8.200 8.402 1.00
head integration_builtins 8.355 ± 0.092 8.206 8.453 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.554 ± 0.101 8.460 8.745 1.01 ± 0.01
head keccak_integration_benchmark 8.490 ± 0.040 8.454 8.578 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.331 ± 0.018 2.312 2.359 1.00
head linear_search 2.332 ± 0.018 2.308 2.359 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.581 ± 0.008 1.571 1.593 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.575 ± 0.008 1.567 1.593 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.443 ± 0.013 1.431 1.467 1.01 ± 0.01
head math_integration_benchmark 1.436 ± 0.006 1.425 1.446 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.265 ± 0.023 1.244 1.325 1.01 ± 0.02
head memory_integration_benchmark 1.255 ± 0.007 1.247 1.266 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.595 ± 0.005 1.590 1.602 1.00
head operations_with_data_structures_benchmarks 1.610 ± 0.015 1.593 1.636 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 608.1 ± 2.0 604.6 610.4 1.01 ± 0.01
head pedersen 604.8 ± 2.5 601.3 609.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.059 ± 0.004 1.049 1.064 1.00 ± 0.01
head poseidon_integration_benchmark 1.058 ± 0.004 1.052 1.064 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.927 ± 0.007 1.916 1.937 1.00 ± 0.00
head secp_integration_benchmark 1.925 ± 0.006 1.919 1.942 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 770.9 ± 1.6 768.7 773.0 1.00 ± 0.00
head set_integration_benchmark 769.8 ± 1.7 767.5 773.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.555 ± 0.035 4.514 4.618 1.00 ± 0.01
head uint256_integration_benchmark 4.544 ± 0.038 4.499 4.596 1.00