search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
504 stars 138 forks source link

Fix cairo1 Felt252DictEntryUpdate hint #1624

Closed juanbono closed 6 months ago

juanbono commented 6 months ago

Fix Felt252DictEntryUpdate hint

Description

Description of the pull request changes and motivation.

Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1f98fef) 97.72% compared to head (7779218) 97.71%.

Files Patch % Lines
...processor/cairo_1_hint_processor/hint_processor.rs 33.33% 4 Missing :warning:
...sor/cairo_1_hint_processor/hint_processor_utils.rs 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1624 +/- ## ========================================== - Coverage 97.72% 97.71% -0.01% ========================================== Files 91 91 Lines 37278 37301 +23 ========================================== + Hits 36429 36448 +19 - Misses 849 853 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.287 ± 0.037 2.256 2.377 1.01 ± 0.02
head big_factorial 2.275 ± 0.021 2.249 2.318 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.241 ± 0.019 2.216 2.280 1.00
head big_fibonacci 2.263 ± 0.037 2.219 2.355 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.561 ± 0.227 8.406 9.166 1.01 ± 0.03
head blake2s_integration_benchmark 8.435 ± 0.024 8.399 8.477 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.316 ± 0.017 2.294 2.341 1.00
head compare_arrays_200000 2.329 ± 0.017 2.309 2.359 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.444 ± 0.018 1.429 1.486 1.00
head dict_integration_benchmark 1.466 ± 0.008 1.453 1.478 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.395 ± 0.031 1.371 1.478 1.00
head field_arithmetic_get_square_benchmark 1.408 ± 0.044 1.381 1.519 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.517 ± 0.138 8.423 8.879 1.00 ± 0.02
head integration_builtins 8.507 ± 0.157 8.426 8.949 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.828 ± 0.217 8.656 9.383 1.00 ± 0.03
head keccak_integration_benchmark 8.784 ± 0.096 8.702 8.942 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.392 ± 0.067 2.333 2.531 1.01 ± 0.03
head linear_search 2.366 ± 0.014 2.344 2.390 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.804 ± 0.014 1.787 1.830 1.00
head math_cmp_and_pow_integration_benchmark 1.815 ± 0.029 1.787 1.891 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.603 ± 0.015 1.588 1.637 1.00
head math_integration_benchmark 1.618 ± 0.015 1.597 1.652 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.272 ± 0.008 1.257 1.287 1.00
head memory_integration_benchmark 1.276 ± 0.008 1.267 1.291 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.906 ± 0.027 1.882 1.975 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.895 ± 0.014 1.882 1.931 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 595.1 ± 10.1 588.1 621.4 1.00
head pedersen 595.5 ± 8.2 590.5 617.8 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 988.6 ± 6.1 981.7 1002.3 1.00
head poseidon_integration_benchmark 991.5 ± 5.7 984.1 1002.2 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.935 ± 0.013 1.916 1.955 1.00
head secp_integration_benchmark 1.941 ± 0.008 1.930 1.957 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 724.3 ± 2.6 720.8 728.1 1.00
head set_integration_benchmark 728.1 ± 3.1 725.0 733.4 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.642 ± 0.032 4.607 4.687 1.00
head uint256_integration_benchmark 4.675 ± 0.079 4.625 4.886 1.01 ± 0.02