search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
514 stars 145 forks source link

Remove `#[allow(deprecated)]` & `#[allow(dead_code)]` #1656

Closed fmoletta closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (ec00e31) to head (b4fab08).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1656 +/- ## ========================================== - Coverage 96.56% 96.56% -0.01% ========================================== Files 95 95 Lines 38407 38403 -4 ========================================== - Hits 37088 37084 -4 Misses 1319 1319 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.290 ± 0.011 2.276 2.309 1.00 ± 0.01
head big_factorial 2.285 ± 0.015 2.253 2.304 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.301 ± 0.022 2.274 2.338 1.00
head big_fibonacci 2.318 ± 0.032 2.291 2.387 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.560 ± 0.385 8.290 9.622 1.02 ± 0.05
head blake2s_integration_benchmark 8.370 ± 0.124 8.264 8.674 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.333 ± 0.011 2.316 2.357 1.00
head compare_arrays_200000 2.335 ± 0.016 2.305 2.365 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.463 ± 0.027 1.445 1.538 1.00
head dict_integration_benchmark 1.474 ± 0.007 1.465 1.483 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.325 ± 0.025 1.292 1.383 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 1.308 ± 0.017 1.290 1.334 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.536 ± 0.162 8.352 8.816 1.00
head integration_builtins 8.570 ± 0.170 8.373 8.786 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.774 ± 0.198 8.577 9.030 1.01 ± 0.03
head keccak_integration_benchmark 8.719 ± 0.145 8.576 8.943 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.363 ± 0.013 2.343 2.385 1.00
head linear_search 2.384 ± 0.012 2.366 2.403 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.597 ± 0.022 1.574 1.635 1.00
head math_cmp_and_pow_integration_benchmark 1.600 ± 0.012 1.590 1.633 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.451 ± 0.006 1.442 1.463 1.00
head math_integration_benchmark 1.453 ± 0.010 1.442 1.471 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.287 ± 0.031 1.263 1.374 1.00 ± 0.03
head memory_integration_benchmark 1.280 ± 0.008 1.261 1.290 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.644 ± 0.015 1.628 1.671 1.00 ± 0.02
head operations_with_data_structures_benchmarks 1.638 ± 0.020 1.618 1.688 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 595.6 ± 2.4 592.7 600.5 1.00
head pedersen 596.2 ± 3.8 593.0 606.0 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 993.1 ± 4.7 986.0 1001.9 1.00 ± 0.01
head poseidon_integration_benchmark 990.3 ± 8.2 978.2 1004.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.879 ± 0.012 1.865 1.897 1.00 ± 0.01
head secp_integration_benchmark 1.873 ± 0.008 1.863 1.887 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 727.4 ± 3.4 722.0 733.0 1.00
head set_integration_benchmark 732.4 ± 6.4 725.9 747.2 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.687 ± 0.063 4.612 4.773 1.00
head uint256_integration_benchmark 4.731 ± 0.094 4.625 4.944 1.01 ± 0.02