Feature: output builtin `add_attribute` method

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.

https://lambdaclass.github.io/cairo-vm

Apache License 2.0

488 stars 133 forks source link

Feature: output builtin `add_attribute` method #1691

Closed odesenfans closed 3 months ago

odesenfans commented 3 months ago

Problem: some OS hints need to add attributes to the output builtin. The Python implementation defines an add_attribute method that is not present in cairo-vm.

Solution: port the add_attribute method.

Description of the pull request changes and motivation.

Checklist

[ ] Linked to Github Issue
[x] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.
- [ ] Documentation has been added/updated.
- [ ] CHANGELOG has been updated.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (42e0416) to head (4add641).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1691 +/- ## ======================================= Coverage 96.56% 96.56% ======================================= Files 95 95 Lines 38409 38422 +13 ======================================= + Hits 37090 37103 +13 Misses 1319 1319 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.