lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
514 stars 144 forks source link

Fix cairo1-run `validate_layouts` #1710

Closed fmoletta closed 5 months ago

fmoletta commented 5 months ago

"recursive" layout was not marked as valid

github-actions[bot] commented 5 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.376 ± 0.122 2.280 2.716 1.04 ± 0.06
head big_factorial 2.294 ± 0.047 2.254 2.418 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.312 ± 0.029 2.263 2.361 1.00
head big_fibonacci 2.329 ± 0.029 2.285 2.373 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.428 ± 0.116 8.309 8.684 1.00
head blake2s_integration_benchmark 8.610 ± 0.196 8.312 8.844 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.383 ± 0.039 2.318 2.435 1.00
head compare_arrays_200000 2.384 ± 0.044 2.320 2.442 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.483 ± 0.027 1.450 1.530 1.01 ± 0.02
head dict_integration_benchmark 1.464 ± 0.011 1.452 1.487 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.298 ± 0.015 1.271 1.315 1.00
head field_arithmetic_get_square_benchmark 1.323 ± 0.027 1.293 1.381 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.578 ± 0.208 8.325 8.908 1.00
head integration_builtins 8.611 ± 0.166 8.325 8.881 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.803 ± 0.171 8.545 9.042 1.00
head keccak_integration_benchmark 8.816 ± 0.182 8.529 9.069 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.405 ± 0.028 2.372 2.444 1.01 ± 0.03
head linear_search 2.387 ± 0.058 2.338 2.530 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.567 ± 0.015 1.531 1.588 1.00
head math_cmp_and_pow_integration_benchmark 1.628 ± 0.046 1.580 1.737 1.04 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.455 ± 0.027 1.427 1.500 1.01 ± 0.02
head math_integration_benchmark 1.441 ± 0.014 1.417 1.459 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.272 ± 0.014 1.255 1.294 1.00
head memory_integration_benchmark 1.305 ± 0.023 1.280 1.353 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.649 ± 0.014 1.633 1.676 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.627 ± 0.020 1.603 1.661 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 595.1 ± 5.4 590.2 606.9 1.00 ± 0.01
head pedersen 593.5 ± 4.0 587.9 601.8 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 993.2 ± 7.2 983.6 1004.5 1.00
head poseidon_integration_benchmark 1002.8 ± 3.9 997.1 1009.8 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.883 ± 0.011 1.863 1.897 1.01 ± 0.01
head secp_integration_benchmark 1.867 ± 0.015 1.849 1.901 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 722.8 ± 3.9 718.4 731.9 1.00
head set_integration_benchmark 734.3 ± 4.4 728.9 744.8 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.694 ± 0.055 4.604 4.774 1.00
head uint256_integration_benchmark 4.744 ± 0.071 4.572 4.823 1.01 ± 0.02
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.98%. Comparing base (6de8f56) to head (1100a19).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1710 +/- ## ======================================= Coverage 94.98% 94.98% ======================================= Files 99 99 Lines 38579 38580 +1 ======================================= + Hits 36646 36647 +1 Misses 1933 1933 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.