search

lambdaclass / cairo-vm

cairo-vm is a Rust implementation of the Cairo VM. Cairo (CPU Algebraic Intermediate Representation) is a programming language for writing provable programs, where one party can prove to another that a certain computation was executed correctly without the need for this party to re-execute the same program.
https://lambdaclass.github.io/cairo-vm
Apache License 2.0
514 stars 144 forks source link

Remove unused `CairoRunner` field `original_steps` #1742

Closed fmoletta closed 5 months ago

github-actions[bot] commented 5 months ago 
**Hyper Thereading Benchmark results**

hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     30.427 s ±  0.080 s    [User: 29.687 s, System: 0.738 s]
  Range (min … max):   30.370 s … 30.484 s    2 runs

Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     30.216 s ±  0.000 s    [User: 29.499 s, System: 0.716 s]
  Range (min … max):   30.215 s … 30.216 s    2 runs

Summary
  'hyper_threading_pr threads: 1' ran
    1.01 ± 0.00 times faster than 'hyper_threading_main threads: 1'

hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     16.256 s ±  0.005 s    [User: 30.218 s, System: 0.740 s]
  Range (min … max):   16.252 s … 16.259 s    2 runs

Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     16.333 s ±  0.016 s    [User: 29.974 s, System: 0.730 s]
  Range (min … max):   16.322 s … 16.344 s    2 runs

Summary
  'hyper_threading_main threads: 2' ran
    1.00 ± 0.00 times faster than 'hyper_threading_pr threads: 2'

hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     12.019 s ±  0.247 s    [User: 41.540 s, System: 0.949 s]
  Range (min … max):   11.844 s … 12.194 s    2 runs

Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.579 s ±  0.237 s    [User: 41.947 s, System: 0.953 s]
  Range (min … max):   11.411 s … 11.746 s    2 runs

Summary
  'hyper_threading_pr threads: 4' ran
    1.04 ± 0.03 times faster than 'hyper_threading_main threads: 4'

hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     11.608 s ±  0.138 s    [User: 41.327 s, System: 1.012 s]
  Range (min … max):   11.510 s … 11.705 s    2 runs

Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     11.697 s ±  0.192 s    [User: 41.864 s, System: 0.917 s]
  Range (min … max):   11.561 s … 11.833 s    2 runs

Summary
  'hyper_threading_main threads: 6' ran
    1.01 ± 0.02 times faster than 'hyper_threading_pr threads: 6'

hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     11.417 s ±  0.163 s    [User: 41.919 s, System: 0.987 s]
  Range (min … max):   11.302 s … 11.532 s    2 runs

Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     11.349 s ±  0.318 s    [User: 42.331 s, System: 0.975 s]
  Range (min … max):   11.125 s … 11.574 s    2 runs

Summary
  'hyper_threading_pr threads: 8' ran
    1.01 ± 0.03 times faster than 'hyper_threading_main threads: 8'

hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     11.369 s ±  0.259 s    [User: 42.411 s, System: 1.009 s]
  Range (min … max):   11.185 s … 11.552 s    2 runs

Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     11.282 s ±  0.243 s    [User: 42.326 s, System: 0.982 s]
  Range (min … max):   11.111 s … 11.454 s    2 runs

Summary
  'hyper_threading_pr threads: 16' ran
    1.01 ± 0.03 times faster than 'hyper_threading_main threads: 16'
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.81%. Comparing base (0df3f34) to head (3e14442).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1742 +/- ## ========================================== - Coverage 94.81% 94.81% -0.01% ========================================== Files 101 101 Lines 38720 38717 -3 ========================================== - Hits 36711 36708 -3 Misses 2009 2009 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.364 ± 0.035 2.340 2.433 1.00
head big_factorial 2.378 ± 0.042 2.340 2.449 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.304 ± 0.023 2.280 2.356 1.00
head big_fibonacci 2.317 ± 0.023 2.294 2.374 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.694 ± 0.112 8.556 8.831 1.00 ± 0.02
head blake2s_integration_benchmark 8.678 ± 0.097 8.574 8.914 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.406 ± 0.033 2.381 2.493 1.00 ± 0.02
head compare_arrays_200000 2.396 ± 0.026 2.378 2.467 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.560 ± 0.019 1.536 1.591 1.00 ± 0.01
head dict_integration_benchmark 1.559 ± 0.004 1.553 1.564 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.434 ± 0.012 1.416 1.454 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.425 ± 0.009 1.420 1.448 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.657 ± 0.135 8.559 9.005 1.00 ± 0.02
head integration_builtins 8.641 ± 0.094 8.550 8.807 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.993 ± 0.304 8.752 9.753 1.01 ± 0.04
head keccak_integration_benchmark 8.924 ± 0.223 8.730 9.490 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.455 ± 0.037 2.411 2.524 1.01 ± 0.02
head linear_search 2.442 ± 0.023 2.415 2.476 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.906 ± 0.011 1.891 1.931 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.905 ± 0.009 1.894 1.924 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.698 ± 0.010 1.679 1.708 1.00
head math_integration_benchmark 1.723 ± 0.040 1.700 1.826 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.344 ± 0.017 1.331 1.387 1.00
head memory_integration_benchmark 1.346 ± 0.038 1.329 1.453 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.983 ± 0.020 1.964 2.018 1.00
head operations_with_data_structures_benchmarks 1.984 ± 0.013 1.968 2.014 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 561.8 ± 2.0 559.2 565.0 1.00
head pedersen 564.3 ± 2.1 562.1 568.5 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.015 ± 0.011 1.004 1.039 1.00 ± 0.01
head poseidon_integration_benchmark 1.010 ± 0.003 1.006 1.015 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.991 ± 0.010 1.978 2.002 1.00
head secp_integration_benchmark 2.011 ± 0.024 1.985 2.052 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 743.4 ± 2.8 738.8 748.5 1.00
head set_integration_benchmark 743.7 ± 6.1 736.8 755.4 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.861 ± 0.100 4.753 5.078 1.01 ± 0.02
head uint256_integration_benchmark 4.826 ± 0.053 4.766 4.923 1.00