Open odesenfans opened 2 months ago
Hi @odesenfans !! Sorry the delay, we didn't saw this PR Can you merge to main and solve the conflicts?
Attention: Patch coverage is 57.26950%
with 241 lines
in your changes missing coverage. Please review.
Project coverage is 94.31%. Comparing base (
63b4a55
) to head (5337a25
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@odesenfans some more points:
t enable the VM to execute this hints in production. There are two ways to solve this, leaving the hints under a feature flag like
cairo-0-secp-hints`, the other way is that you implement your own hint processor in your repopop().unwrap();
and some more cases@pefontana The requested changes and integration tests have been added. Please feel free to run the workflows and review the code.
@whichqua sorry for the delay, you can ping me on telegram if I don't respond here https://t.me/Pedrofontana5 Some CI checks are failing
@JulianGCalderon @pefontana Let me know if there is anything else needed. Would be nice to get the tests passing.
Hi @whichqua, two jobs seem to be failing:
The second job fails because the hint is not found. This is because this job on the CI runs all the standalone files in cairo_programs
and compares it's execution. You could try to move these files to another directory cairo_programs/cairo-0-secp-hints-feature
and see if it fixes it. Keep in mind that this will probably fix the CI, but it will not fix the underlying error that is breaking the first job.
Context: port of the Starknet OS to Rust.
We need an implementation of the hints used by the Starknet OS in the SECP syscalls. These hints rely on private primitives in
cairo-vm
and must be implemented in this repository.Checklist