lambdaclass / champions_of_mirra

Curse of Mirra game codebase
https://curseofmirra.com/
Apache License 2.0
42 stars 4 forks source link

[GH-1831] Add toggle bots button #1840

Closed Nico-Sanchez closed 2 weeks ago

Nico-Sanchez commented 3 weeks ago

[!IMPORTANT]
This PR must be merged along with https://github.com/lambdaclass/mirra_backend/pull/693

Closes #1831

Motivation

We need a way to disable/enable the bots as pleased, for testing purposes.

Summary of changes

How has this been tested?

Just play a game and toggle BOTS in settings > dev tab. Make sure you use the following backend branch -> https://github.com/lambdaclass/mirra_backend/pull/693

Checklist

Nico-Sanchez commented 3 weeks ago

image Do you think something could be made to avoid this message? Or is it printed for a reason?

This happens when bots are turned on or off, since the toggle bots message that the backend broadcasts isn't handled in GameServerConnectionManager.cs

I didn't add this print and I find it useful. You can see in your console any unhandled message you receive.

tkz00 commented 3 weeks ago

image Do you think something could be made to avoid this message? Or is it printed for a reason? This happens when bots are turned on or off, since the toggle bots message that the backend broadcasts isn't handled in GameServerConnectionManager.cs

I didn't add this print and I find it useful. You can see in your console any unhandled message you receive.

Yeah, I meant to disable the print specifically for the message ToggleBots to not clog the console, since it's normal the client doesn't handle it, I believe the correct way of "handling" that message is doing nothing, and leaving the log for any other unexpected messages, but if you feel it's better to leave it for visibility it's ok too.

Nico-Sanchez commented 3 weeks ago

image Do you think something could be made to avoid this message? Or is it printed for a reason? This happens when bots are turned on or off, since the toggle bots message that the backend broadcasts isn't handled in GameServerConnectionManager.cs

I didn't add this print and I find it useful. You can see in your console any unhandled message you receive.

Yeah, I meant to disable the print specifically for the message ToggleBots to not clog the console, since it's normal the client doesn't handle it, I believe the correct way of "handling" that message is doing nothing, and leaving the log for any other unexpected messages, but if you feel it's better to leave it for visibility it's ok too.

Oh I get what you mean, you're totally right. I'll fix it.