Closed AngieDutra closed 1 week ago
I have one comment I would like to discuss We have images smaller that the max size. I think the muflus's fire assets could be smaller without loosing quality in the mobile game but they don't present a huge difference and work well as they are now too
I feel the fire in the head seems kind of weird, like it's another art style than the 3D model, also it seems to grow to the inside, like a cone with it's pointy end to the top. I've raise these concerns to the art team and will wait on their response to continue with the review.
I talked with the art team and they decided to move forward with this PR as it is and later on try to improve it since the vfx team has other priorities at the moment
I believe it could afford to be lower. The accurate way to test this would be in a mobile build. Do you have screens for both cases? So I can check if there is really no difference?
Here are my tests. IMO there is a noticeable difference
High quality:
Low quality:
I'll try out a middle quality just to find a happy middle ground
Tested 64 and it looks good. Let me know what you guys think
Closes #1742
Motivation
Muflus's fire was missing in the UI
Summary of changes
https://github.com/lambdaclass/champions_of_mirra/assets/82987608/9b435dc4-46d7-494e-82f6-dd54f32e0bf4
How has this been tested?
This fire in the UI should show in:
Checklist