lambdaclass / champions_of_mirra

Curse of Mirra game codebase
https://curseofmirra.com/
Apache License 2.0
42 stars 4 forks source link

[DOC] Build settings documentation #1862

Closed AngieDutra closed 3 days ago

AngieDutra commented 1 week ago

Motivation

The Unity Development team didn't have a build settings guide and it started to cause issues

Summary of changes

This PR adds to our documentation a Build Settings section with our ideal settings for the game

How has this been tested?

I followed it and tested both playing the game and using ngrok

Checklist

AngieDutra commented 1 week ago

I'll ask Nico for the first part. Regarding the build and run button, should it be in the settings section or added to the "build on IOS" section?

mgrunwaldt commented 1 week ago

I'll ask Nico for the first part

Great!

Regarding the build and run button, should it be in the settings section or added to the "build on IOS" section?

I don't have a hard answer, I'd put it in here but both work, whatever you think is better works

Nico-Sanchez commented 1 week ago

The work is good, but I think that you should also add that for Android under publishing settings you need to use the same keystore and user that was used for Google Sign In @Nico-Sanchez could you confirm to me which one it is?

Hmmm, that keystore is only for the ones who build the app to upload it to google store. If you meant that we need that keystore to log in with Google with our own builds, that doesn't work, and it's not solved yet. We can discuss this further in Slack if needed.

AngieDutra commented 1 week ago

Until we decide what exactly to add, I'll set this to draft