lambdaclass / champions_of_mirra

Curse of Mirra game codebase
https://curseofmirra.com/
Apache License 2.0
42 stars 4 forks source link

Fix flow for username with less than 4 characters #1879

Closed tkz00 closed 1 day ago

tkz00 commented 4 days ago

Closes #1815

Motivation

There is an error where if you input a username with less than 4 characters, the popup will become transparent, but still be there, blocking the flow of the application, instead of showing the respective error. [BUG] User flow broken if name less than 4 characters

Summary of changes

How has this been tested?

Clear your player prefs (cache on iOS or android), and set a name, try to edit it, try to put less than 4 characters, save while leaving the input empty, test that flow feels right. Remember it shouldn't let you set usernames with less than 4 characters.

References: Screenshot_20240701_115021_client Screenshot_20240701_115029_client Screenshot_20240701_115100_client

Checklist

tkz00 commented 3 days ago

I see no point in showing an x button if I'll never be able to use it in that instance. Could we not show it in this case and ave it enabled if the user already has a name set? Screenshot 2024-07-02 at 13 23 30

Agree! The change has been made.

AngieDutra commented 1 day ago

IMO this is more of a path tho and the real issue remains. Why would everything crash if I have 3 letters in my name? That is the ting to fix also