lambdaclass / concrete

Concrete is a simple programming language specifically crafted for creating highly scalable systems that are reliable, efficient, and easy to maintain.
Apache License 2.0
123 stars 11 forks source link

testcases in concrete_driver examples includes check phase for linearity check coverage #142

Open kenarab opened 3 months ago

kenarab commented 3 months ago

It can be checked, for example, at codecov or in codecov report bellow we are now covering linearity_check.rs source file.

Linearity check algorithm can be aknowledged as completed when fn check_var_in_expr coverage of match statement is fully covered. It is expected to cover not with examples .con file, but manually building the conditions for coverage, as the current status of the parser is possible not to satisfy all conditions from a parsed source code.

github-actions[bot] commented 3 months ago

Benchmarking factorial

Compiling factorial (factorial.con) Finished release in 29.862963ms Running 5000000 iterations Using input value: 20 Concrete Result = 2432902008176640000 Time taken : 60.28 ms Rust Result = 2432902008176640000 Time taken : 60.16 ms

Benchmarking fib

Compiling fib (fib.con) Finished release in 26.321901ms Running 5000 iterations Using input value: 20 Concrete Result = 6765 Time taken : 135.92 ms Rust Result = 6765 Time taken : 90.48 ms

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 60.13%. Comparing base (9575fbe) to head (5bc16e4).

Files Patch % Lines
crates/concrete_driver/src/lib.rs 0.00% 15 Missing :warning:
crates/concrete_check/src/linearity_check.rs 78.94% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ========================================== + Coverage 54.57% 60.13% +5.56% ========================================== Files 27 27 Lines 5387 5381 -6 ========================================== + Hits 2940 3236 +296 + Misses 2447 2145 -302 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.