lambdaclass / lambdaworks

lambdaworks offers implementations for both SNARKs and STARKs provers, along with the flexibility to leverage their individual components for constructing customized SNARKs.
https://lambdaclass.github.io/lambdaworks/
Apache License 2.0
625 stars 140 forks source link

Add Jacobian coordinates for Short Weierstrass #917

Closed jotabulacios closed 2 months ago

jotabulacios commented 2 months ago

Add Jacobian coordinates

Description

This PR adds Jacobian coordinates for Short Weierstrass elliptic curves.

Type of change

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.61837% with 69 lines in your changes missing coverage. Please review.

Project coverage is 73.36%. Comparing base (d663fdf) to head (899c1e1).

Files with missing lines Patch % Lines
math/src/elliptic_curve/short_weierstrass/point.rs 75.00% 58 Missing :warning:
math/src/elliptic_curve/point.rs 78.43% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #917 +/- ## ========================================== + Coverage 73.34% 73.36% +0.01% ========================================== Files 155 155 Lines 35328 35611 +283 ========================================== + Hits 25913 26127 +214 - Misses 9415 9484 +69 ``` | [Flag](https://app.codecov.io/gh/lambdaclass/lambdaworks/pull/917/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/lambdaclass/lambdaworks/pull/917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | `73.36% <75.61%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.