Add Yas swap benchmarks - Githubissues

lambdaclass / starknet-replay

Provides a way of reading a real Starknet State, so you can re-execute an existing transaction in any of the Starknet networks in an easy way

Apache License 2.0

6 stars 1 forks source link

Add Yas swap benchmarks #22

Open pefontana opened 4 months ago

pefontana commented 4 months ago

The idea is to benchmark the Yas swap execution using criterion, like we did in starknet_in_rust crate https://github.com/lambdaclass/starknet_in_rust/blob/99c7b3b29a78cf8a27cc61bcdc029ed4255817ad/bench/yas.rs For what I know, there are two options to replicate this benchmarks:

The way we do it in Starknet in rust: Create the transactions in rust, deploying the account and the yas contract and making an invoke tx to execute the swap
Get an invoke tx that invoke the yas contract and execute it We need to evaluate what option is better and implement it

Note. The idea of the benchmark is to execute the swap many times, so we can have a better benchmarks

FrancoGiachetta commented 3 weeks ago

I think we should we close this issue since it's already done en the blockifier. Though we should probably port it to the sequencer.