search

lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic
Apache License 2.0
171 stars 52 forks source link

Add bounds for out of range check in get_block_hash syscall #1167

Closed toni-calvin closed 11 months ago

toni-calvin commented 11 months ago

TITLE

Description

This PR fixes #1166

Description of the pull request changes and motivation.

Checklist

codecov-commenter commented 11 months ago

Codecov Report

Merging #1167 (48bf482) into main (abeefe7) will decrease coverage by 0.15%. The diff coverage is 0.00%.

:exclamation: Current head 48bf482 differs from pull request most recent head 8f91882. Consider uploading reports for the commit 8f91882 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1167/graphs/tree.svg?width=650&height=150&src=pr&token=98QY5B0VAR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) ```diff @@ Coverage Diff @@ ## main #1167 +/- ## ========================================== - Coverage 89.61% 89.47% -0.15% ========================================== Files 50 50 Lines 14370 14369 -1 ========================================== - Hits 12878 12856 -22 - Misses 1492 1513 +21 ``` | [Files](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | Coverage Δ | | |---|---|---| | [src/syscalls/business\_logic\_syscall\_handler.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3N5c2NhbGxzL2J1c2luZXNzX2xvZ2ljX3N5c2NhbGxfaGFuZGxlci5ycw==) | `78.81% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1167/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)