search

lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic
Apache License 2.0
171 stars 52 forks source link

[0.13] Move handle_nonce call before check_fee_balance in DeployAccount, Declare & InvokeFunction txs #1200

Closed pefontana closed 9 months ago

pefontana commented 9 months ago

Move handle_nonce

Move handle_nonce call before check_fee_balance in DeployAccount, Declare, DeclareV2 and InvokeFunction txs

Checklist

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (03f716c) 89.37% compared to head (7e6ffee) 89.65%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200/graphs/tree.svg?width=650&height=150&src=pr&token=98QY5B0VAR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) ```diff @@ Coverage Diff @@ ## main #1200 +/- ## ========================================== + Coverage 89.37% 89.65% +0.28% ========================================== Files 50 50 Lines 14455 14215 -240 ========================================== - Hits 12919 12745 -174 + Misses 1536 1470 -66 ``` | [Files](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | Coverage Δ | | |---|---|---| | [src/transaction/declare.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2RlY2xhcmUucnM=) | `90.71% <ø> (-0.10%)` | :arrow_down: | | [src/transaction/declare\_v2.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2RlY2xhcmVfdjIucnM=) | `88.95% <ø> (-0.12%)` | :arrow_down: | | [src/transaction/deploy\_account.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2RlcGxveV9hY2NvdW50LnJz) | `76.13% <ø> (-0.04%)` | :arrow_down: | | [src/transaction/invoke\_function.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2ludm9rZV9mdW5jdGlvbi5ycw==) | `95.60% <ø> (-0.06%)` | :arrow_down: | ... and [35 files with indirect coverage changes](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1200/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)