lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic

Apache License 2.0

171 stars 52 forks source link

Add bitcoin curve support. #1218

Closed azteca1998 closed 8 months ago

azteca1998 commented 9 months ago

Add bitcoin curve syscalls support

Description

Add support for the following syscalls:

secp256k1_new_syscall
secp256k1_add
secp256k1_mul
secp256k1_get_xy
secp256r1_new_syscall
secp256r1_add
secp256k1_mul
secp256r1_get_xy

Remaining syscalls:

secp256k1_get_point_from_x
secp256r1_get_point_from_x

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.
- [ ] Documentation has been added/updated.

azteca1998 commented 8 months ago

Returning an error there would mean sending said error into Cairo from our side. Should I do that regardless?