lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic
Apache License 2.0
171 stars 52 forks source link

Rename `Declare` to `DeclareDeprecated` & `DeclareV2` to `Declare` #1220

Closed fmoletta closed 8 months ago

fmoletta commented 9 months ago

Closes #1208 Based on #1210 for convenience

codecov-commenter commented 9 months ago

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (8f9b552) 88.97% compared to head (62b19c2) 88.96%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220/graphs/tree.svg?width=650&height=150&src=pr&token=98QY5B0VAR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) ```diff @@ Coverage Diff @@ ## main #1220 +/- ## ========================================== - Coverage 88.97% 88.96% -0.02% ========================================== Files 52 52 Lines 15604 15588 -16 ========================================== - Hits 13884 13868 -16 Misses 1720 1720 ``` | [Files](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | Coverage Δ | | |---|---|---| | [src/core/transaction\_hash/deprecated.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvdHJhbnNhY3Rpb25faGFzaC9kZXByZWNhdGVkLnJz) | `99.63% <100.00%> (ø)` | | | [src/lib.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2xpYi5ycw==) | `98.23% <100.00%> (ø)` | | | [src/transaction/error.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2Vycm9yLnJz) | `75.00% <ø> (ø)` | | | [src/core/transaction\_hash/current.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvdHJhbnNhY3Rpb25faGFzaC9jdXJyZW50LnJz) | `88.74% <0.00%> (ø)` | | | [src/core/transaction\_hash/mod.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvdHJhbnNhY3Rpb25faGFzaC9tb2QucnM=) | `60.33% <66.66%> (ø)` | | | [src/transaction/mod.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL21vZC5ycw==) | `50.54% <36.36%> (ø)` | | | [src/transaction/declare.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2RlY2xhcmUucnM=) | `88.87% <86.90%> (-2.50%)` | :arrow_down: | | [src/transaction/declare\_deprecated.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2RlY2xhcmVfZGVwcmVjYXRlZC5ycw==) | `91.36% <91.36%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1220/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)