search

lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic
Apache License 2.0
171 stars 52 forks source link

Move `Address` to transaction module + add utility impls #1227

Closed fmoletta closed 8 months ago

fmoletta commented 9 months ago

Closes #1223

codecov-commenter commented 9 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (15a1e6e) 89.07% compared to head (7d5d2e6) 88.99%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227/graphs/tree.svg?width=650&height=150&src=pr&token=98QY5B0VAR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) ```diff @@ Coverage Diff @@ ## main #1227 +/- ## ========================================== - Coverage 89.07% 88.99% -0.09% ========================================== Files 52 52 Lines 15586 15601 +15 ========================================== Hits 13884 13884 - Misses 1702 1717 +15 ``` | [Files](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | Coverage Δ | | |---|---|---| | [src/core/errors/state\_errors.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvZXJyb3JzL3N0YXRlX2Vycm9ycy5ycw==) | `50.00% <ø> (ø)` | | | [src/core/transaction\_hash/current.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvdHJhbnNhY3Rpb25faGFzaC9jdXJyZW50LnJz) | `88.74% <ø> (ø)` | | | [src/core/transaction\_hash/deprecated.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvdHJhbnNhY3Rpb25faGFzaC9kZXByZWNhdGVkLnJz) | `99.63% <ø> (ø)` | | | [src/core/transaction\_hash/mod.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2NvcmUvdHJhbnNhY3Rpb25faGFzaC9tb2QucnM=) | `60.33% <ø> (ø)` | | | [src/definitions/block\_context.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2RlZmluaXRpb25zL2Jsb2NrX2NvbnRleHQucnM=) | `96.39% <ø> (ø)` | | | [src/execution/execution\_entry\_point.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2V4ZWN1dGlvbi9leGVjdXRpb25fZW50cnlfcG9pbnQucnM=) | `94.77% <ø> (ø)` | | | [src/execution/gas\_usage.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2V4ZWN1dGlvbi9nYXNfdXNhZ2UucnM=) | `100.00% <ø> (ø)` | | | [src/execution/mod.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2V4ZWN1dGlvbi9tb2QucnM=) | `90.87% <ø> (ø)` | | | [src/hash\_utils.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2hhc2hfdXRpbHMucnM=) | `99.02% <ø> (ø)` | | | [src/lib.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2xpYi5ycw==) | `98.23% <ø> (ø)` | | | ... and [22 more](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1227?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | |