search

lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic
Apache License 2.0
171 stars 52 forks source link

Fix CI coverage step: remove nightly #1228

Closed fmoletta closed 9 months ago

fmoletta commented 9 months ago

The CI is currently broken due to a failure in the coverage job This PR fixes it by running the coverage generation in stable rust and not nightly

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4ff4538) 88.50% compared to head (3a27e24) 89.04%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1228/graphs/tree.svg?width=650&height=150&src=pr&token=98QY5B0VAR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) ```diff @@ Coverage Diff @@ ## main #1228 +/- ## ========================================== + Coverage 88.50% 89.04% +0.53% ========================================== Files 52 52 Lines 14819 15495 +676 ========================================== + Hits 13116 13797 +681 + Misses 1703 1698 -5 ``` [see 49 files with indirect coverage changes](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)