search

lambdaclass / starknet_in_rust

A Rust implementation of Starknet execution logic
Apache License 2.0
171 stars 52 forks source link

Include the entry point selector in `EntryPointNotFound` error #1251

Closed kariy closed 7 months ago

kariy commented 7 months ago

Description

Include the selector felt value in the error, so that we can display the selector in the error message

Checklist

juanbono commented 7 months ago

Thanks for your contribution!!

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.94%. Comparing base (d011ebe) to head (cd8c623).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1251/graphs/tree.svg?width=650&height=150&src=pr&token=98QY5B0VAR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass)](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) ```diff @@ Coverage Diff @@ ## main #1251 +/- ## ======================================= Coverage 88.94% 88.94% ======================================= Files 52 52 Lines 15610 15618 +8 ======================================= + Hits 13884 13892 +8 Misses 1726 1726 ``` | [Files](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1251?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass) | Coverage Δ | | |---|---|---| | [src/execution/execution\_entry\_point.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL2V4ZWN1dGlvbi9leGVjdXRpb25fZW50cnlfcG9pbnQucnM=) | `94.83% <100.00%> (+0.04%)` | :arrow_up: | | [src/transaction/error.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2Vycm9yLnJz) | `100.00% <ø> (ø)` | | | [src/transaction/invoke\_function.rs](https://app.codecov.io/gh/lambdaclass/starknet_in_rust/pull/1251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lambdaclass#diff-c3JjL3RyYW5zYWN0aW9uL2ludm9rZV9mdW5jdGlvbi5ycw==) | `95.83% <100.00%> (+0.01%)` | :arrow_up: |