lambdaclass / zksync-web3-rs

MIT License
32 stars 17 forks source link

Make API consistent #83

Closed mpaulucci closed 1 year ago

mpaulucci commented 1 year ago

We're using the builder pattern in some cases:

We need to add consistency across the board. For example, create a WithdrawalRequest in similar fashion.

As part of this taks we should also look into other potential consistency issues.

0xPetra commented 1 year ago

Hi there! I'm hacking a desktop wallet with Tauri (similar to Electron but in Rust) and I'm trying to create a smart account with a spending limit.

I can't see any reference to AA and the IAccount interface. Am I missing something? My DMs are open on tg @petra0x if you want to reach out.

Thx!

mpaulucci commented 1 year ago

Hi @0xPetra . We haven't implemented account abstraction yet in the Rust SDK. I think the Python SDK might have it: https://github.com/zksync-sdk/zksync2-python/blob/master/examples/13_deploy_account_create.py

0xPetra commented 1 year ago

Since I’m using Tauri (which has a Rust backend) I needed this one.

Any timeline or hack I can realize? I’m a noob in Rust. Otherwise I would try to integrate myself.

On Tue, 11 Jul 2023 at 17:17 Martin Paulucci @.***> wrote:

Hi @0xPetra https://github.com/0xPetra . We haven't implemented account abstraction yet in the Rust SDK. I think the Python SDK might have it: https://github.com/zksync-sdk/zksync2-python/blob/master/examples/13_deploy_account_create.py

— Reply to this email directly, view it on GitHub https://github.com/lambdaclass/zksync-web3-rs/issues/83#issuecomment-1631020190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZAN22YC2VI5CDQASMXVWDXPVU7BANCNFSM6AAAAAA2EYYMP4 . You are receiving this because you were mentioned.Message ID: @.***>

--

https://www.linhub.co/

http://twitter.com/0xPetra Franco Petra

*0xpetra.com http://0xpetra.com | *.eth https://etherscan.io/address/0x9fc3b33884e1d056a8ca979833d686abd267f9f8