A lot of important, yet "stringly" types

lambdacube3d / lambdacube-gl

OpenGL 3.3 Core Profile backend for LambdaCube 3D

http://lambdacube3d.com/getting-started

Other

22 stars 8 forks source link

A lot of important, yet "stringly" types #6

Open deepfire opened 7 years ago

deepfire commented 7 years ago

The abundance of String-typed objects passed around makes it more difficult to navigate the project.

deepfire commented 7 years ago

Current list of candidates for creative newtype-ing:

uniform names (as in keys of PipelineSchema.uniforms)
object array names (as in keys of PipelineSchema.objectArrays)
slot names (as in slotName arg of Input.addObject, also in GLStorage.slotMap)
attribute names (as in keys of the attribs arg of Input.addObject)

deepfire commented 7 years ago

@csabahruska, would you like to outsource this somewhat massive refactoring, or would it be less trouble for you to do it yourself?

Seeing how this touches three projects at once:

lambdacube-ir, because of PipelineSchema
lambdacube-gl, because of above and GLStorage and attribute-related types
lambdacube-quake3, because of all of the above and still more that I didn't mention here

..I can imagine that it can be quite daunting..

csabahruska commented 7 years ago

Thanks for the feedback. I agree it's a good idea to use newtypes for these names. I can do the refactoring in 3-4 days.

csabahruska commented 7 years ago

This will take more time, because I have to add newtype support for the Data Definition Language EDSL, that is used to generate lambdacube-ir for multiple languages (hs, purs, c++, java, etc.)