search

lambdageek / unbound-generics

Specify variable binding in syntax trees using GHC.Generics (reimplementation of Unbound)
https://hackage.haskell.org/package/unbound-generics/
BSD 3-Clause "New" or "Revised" License
55 stars 18 forks source link

Help Wanted: Looking for co-maintainer #55

Open lambdageek opened 1 year ago

lambdageek commented 1 year ago

April 2023: I (@lambdageek ) am not working on this package very actively anymore. I would love a co-maintainer who could invest some time in making sure that everything keeps working (and perhaps even address some of the long-standing issues).

erlandsona commented 1 year ago

:wave: I'd be interested in this if you want to sync up sometime and help me get a bit more familiar than just what I have here. https://github.com/erlandsona/pipes

lambdageek commented 12 months ago

@erlandsona Sorry it took me a bit to get back to you. I'd love your help with maintaining this package. I'm a little bit concerned that you haven't contributed to this package before, and it's a bit hard to tell from your GitHub history if you have some experience with working with haskell packages and with Hackage before. It's fine if you don't, but I think we should go kind of gradually in giving you access to the repo and adding you as a maintainer on Hackage.

Here's what I propose:

  1. Open a PR adding yourself to the .cabal file Author field
  2. Investigate whether we can bump our ansi-wl-pprint dependency to the latest (1.0.2) as mentioned in https://github.com/commercialhaskell/stackage/issues/6981 and open a PR for that as well.
  3. Once that PR goes in, prepare a candidate package to upload to Hackage and send me the tarball to review. We'll discuss it and if it looks good, I'll give you access to upload it to hackage.

Sounds goods?

erlandsona commented 11 months ago

Aight 1 - https://github.com/lambdageek/unbound-generics/pull/58 2 - https://github.com/lambdageek/unbound-generics/pull/59

I'm not sure if there's anything specifically I should be looking for with 2 tho. I bumped the package, ran cabal build && cabal test and everything seemed to look the same as before?

Also, I'm not sure these items really qualify me for "maintainer"? I've still only done a toy project with this lib and have very little understanding of how most of it works :sweat_smile: (my imposter syndrome is burning something fierce).

lambdageek commented 11 months ago

Aight 1 - https://github.com/lambdageek/unbound-generics/pull/58

2 - https://github.com/lambdageek/unbound-generics/pull/59

I'm not sure if there's anything specifically I should be looking for with 2 tho. I bumped the package, ran cabal build && cabal test and everything seemed to look the same as before?

That's probably good enough. I didn't look at the changelog for pprint - do we know why they bumped the major version? It's possible it doesn't affect us, so we wouldn't expect that we need to change anything.

Also, I'm not sure these items really qualify me for "maintainer"? I've still only done a toy project with this lib and have very little understanding of how most of it works :sweat_smile: (my imposter syndrome is burning something fierce).

I think that's fine. I have some bandwidth to help out if there are tricky issues. Just not a lot of time to do long term maintenance and development.

erlandsona commented 11 months ago

Just not a lot of time to do long term maintenance and development.

To be honest, I work a 9-5 and I have a 7mo old infant so not sure I have much time for long term maintenance / development either :sweat: I was mostly hoping that by interacting here I might be able to dip my toes into the lib a little better than just what I did with my toy project :shrug:

erlandsona commented 11 months ago

Thing is if I knew the lib well enough for my own means, then committing to something like merging PR's and bumping versions and stuff is pretty trivial. Running/Managing a CI stack and ensuring backwards compat without understanding the project is another thing.

lambdageek commented 11 months ago

Just not a lot of time to do long term maintenance and development.

To be honest, I work a 9-5 and I have a 7mo old infant so not sure I have much time for long term maintenance / development either 😓

Same. (Well... my kiddo is 3½ now, but that age doesn't free up much time, tbh)

I was mostly hoping that by interacting here I might be able to dip my toes into the lib a little better than just what I did with my toy project 🤷

Maybe try and tackle https://github.com/lambdageek/unbound-generics/issues/50 ?

erlandsona commented 11 months ago

Same. (Well... my kiddo is 3½ now, but that age doesn't free up much time, tbh)

Dads Unite!

Maybe try and tackle https://github.com/lambdageek/unbound-generics/issues/50 ?

Yeh that looks like a fun one!