search

lambdageek / unbound-generics

Specify variable binding in syntax trees using GHC.Generics (reimplementation of Unbound)
https://hackage.haskell.org/package/unbound-generics/
BSD 3-Clause "New" or "Revised" License
56 stars 18 forks source link

Bumped ansi-wl-pprint to 1.0.2 and everything seems to build fine. #59

Closed erlandsona closed 1 year ago

erlandsona commented 1 year ago

Haven't done any testing tho :thinking:.

@lambdageek Anything, I should be looking for specifically?

lambdageek commented 1 year ago

Generally I just try to run some of the examples locally and look at the output.

To be honest I don't remember why we even have a pprint dependency. Do we have pretty printer instances for the language combinators?

lambdageek commented 1 year ago

One thing you should probably do is get familiar with ghcup and building unbound-generics with older versions of ghc. Most of our problems with version bumps happen when an older compiler doesn't like new code for some reason.

I generally try to keep everything working with old versions of GHC because sometimes academic projects use us (like some student will do a master's thesis project or something) and they generally don't update after the paper is done. And if someone comes along and tries to use their project later, it's nice if they can still build it.

That said, if some 10-year version of GHC doesn't build in Github Actions anymore, I don't feel too bad about dropping support. (Like with 7.10 earlier this year)