Fix bug where records with deletions are not handled

lambdaisland / deep-diff2

Deep diff Clojure data structures and pretty print the result

Eclipse Public License 1.0

296 stars 18 forks source link

Fix bug where records with deletions are not handled #30

Closed ProjectFrank closed 8 months ago

ProjectFrank commented 2 years ago

Fixes #29.

plexus commented 2 years ago

I'm going to leave this open for now. If we want to put out a bugfix release for deep-diff1 we'd have to start by fixing the CI setup, and bringing our lambdaisland toolchain setup up to date (see bin/proj and bb.edn).

deep-diff2 has been out for a few years, and upgrading should be very straightforward, so unless someone comes around who is running into this issue and for some reason is unable to upgrade, I don't think there's enough reason to put effort into this.

plexus commented 1 year ago

To clarify for people coming across this issue. The aforementioned bug has been fixed in deep-diff2, this PR is specifically for the old deep-diff(1). We could release a new version of deep-diff1 with the fix, but there's some effort involved, and no one might really need it, so we're punting on this until someone steps up and explains why they need this.