search

lambdaisland / deep-diff2

Deep diff Clojure data structures and pretty print the result
Eclipse Public License 1.0
296 stars 18 forks source link

Babashka compatibility #36

Closed borkdude closed 1 year ago

borkdude commented 1 year ago

This PR adds babashka compatibility to deep-diff2

borkdude commented 1 year ago

This needs to be executed with bb from master for now:

bash <(curl https://raw.githubusercontent.com/babashka/babashka/master/install) --version 1.0.166-SNAPSHOT --dir .
./bb test:bb

Not sure how to add this to the CircleCI config.

Also this depends on a git dep of clj-diff, so we might want to wait for a mvn release of that first.

borkdude commented 1 year ago

The updated PR should now work with the latest stable release of bb.

I have looked into how to test this in CI, but I'm not familiar enough with the orb / templating stuff. Any pointers would be appreciated.

plexus commented 1 year ago

yeah it's convoluted... FWIW the orb sources are here https://github.com/lambdaisland/open-source/tree/main/circleci

I'd be ok with having a github action for the bb tests, and still running the kaocha tests on circle, since that's what we still default to for most of our projects... I don't particularly like either of them which also means I don't have a particular preference :)

borkdude commented 1 year ago

@plexus I'll add a github config for bb tests

borkdude commented 1 year ago

Somehow it's not finding lambdaisland.deepdiff-2.runner in the Github Action, while it works correctly for me local (on an M1 Air). But when I use act to run the Action locally, I can reproduce what happens in CI... investigating.

borkdude commented 1 year ago

@plexus Ready for review. You can see the Github tests running here: https://github.com/borkdude/lambdaisland-deep-diff2/tree/babashka

plexus commented 1 year ago

Fabulous!

released in

[lambdaisland/deep-diff2 "2.6.166"]
{lambdaisland/deep-diff2 {:mvn/version "2.6.166"}}