search

lambdaisland / glogi

A ClojureScript logging library based on goog.log
Mozilla Public License 2.0
119 stars 13 forks source link

Issues with ClojureScript 1.10.844 #10

Closed ak-coram closed 3 years ago

ak-coram commented 3 years ago

The new ClojureScript release includes the Closure Library version 0.0-20201211-3e6c510d, which contains some breaking changes regarding the logging modules:

https://clojurescript.org/news/2021-04-06-release

These changes seem to make glögi inoperable:

WARNING: Wrong number of args (1) passed to goog.log/getLogger at line 34 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/SHOUT at line 42 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/FINEST at line 49 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/CONFIG at line 46 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/WARNING at line 55 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/FINER at line 53 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/FINE at line 54 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/ALL at line 50 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/WARNING at line 44 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/SEVERE at line 43 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/OFF at line 41 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/INFO at line 45 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/FINE at line 47 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/SEVERE at line 56 target/cljs/lambdaisland/glogi.cljs
WARNING: Use of undeclared Var goog.debug.Logger.Level/FINER at line 48 target/cljs/lambdaisland/glogi.cljs
ak-coram commented 3 years ago

Sorry, my mistake: I see there's already a new release which fixes the compatibility issues. I still get these warnings though.

plexus commented 3 years ago

Thanks for the report, we might have missed something. I'll have a look.

plexus commented 3 years ago

Hey @ak-coram any chance you could try out https://github.com/lambdaisland/glogi/pull/11 ? I'm holding off on merging because I want to figure out the CI setup this time, but it should work fine now on both current and older ClojureScripts.

ak-coram commented 3 years ago

@plexus: most of the warnings are gone with #11, this is the only one remaining:

WARNING: Wrong number of args (1) passed to goog.log/getLogger at line 64 /home/ak/.gitlibs/libs/lambdaisland/glogi/f4434c47684a8c5006008aea51790fe44d5d49ba/src/lambdaisland/glogi.cljs

I'm guessing using apply would get rid of the arity check (and the warning) if that's what you're after.

plexus commented 3 years ago

Strangely I'm not able to reproduce that warning, but I pushed a fix for it nonetheless, please try out:

[lambdaisland/glogi "1.0.100"]
{lambdaisland/glogi {:mvn/version "1.0.100"}}
ak-coram commented 3 years ago

@plexus: thank you, there are no more warnings with this version.