Closed ak-coram closed 3 years ago
Hi, the new version of lambdaisland.glogi/logger in 1.0.100 seems to unintentionally set the level of the logger to nil when called with a single argument:
lambdaisland.glogi/logger
nil
l.glogi> (logger "" (:config levels)) #js{:getName #object[getName], :__glogi_handlers__ {#object[Function] #object[log_record_handler]}} l.glogi> (glog/getLevel root-logger) #object[Level CONFIG] l.glogi> (logger "") #js{:getName #object[getName], :__glogi_handlers__ {#object[Function] #object[log_record_handler]}} l.glogi> (glog/getLevel root-logger) nil
This is done to the root logger when the namespace is first loaded (via (def root-logger (logger ""))), leading to various issues: https://github.com/bhauman/figwheel-main/issues/289
(def root-logger (logger ""))
This change passes js/undefined to goog.log/getLogger instead of nil to keep the original level of the logger intact.
js/undefined
goog.log/getLogger
Thanks! will put this out right away.
Released in
[lambdaisland/glogi "1.0.106"] {lambdaisland/glogi {:mvn/version "1.0.106"}}
Hi, the new version of
lambdaisland.glogi/logger
in 1.0.100 seems to unintentionally set the level of the logger tonil
when called with a single argument:This is done to the root logger when the namespace is first loaded (via
(def root-logger (logger ""))
), leading to various issues: https://github.com/bhauman/figwheel-main/issues/289This change passes
js/undefined
togoog.log/getLogger
instead ofnil
to keep the original level of the logger intact.