Open alysbrooks opened 1 year ago
Based on looking into it further, MPL and EPL are very similar and as far as I can tell, can be combined freely.
Latest version of Reagent's test suite: https://github.com/reagent-project/reagent/blob/master/src/reagent/impl/template.cljs. While I'm just integrating Hiccup tests for now, I'm trying to avoid introducing any incompatibilities.
I think we can merge this after #5.
I believe that #7 would have been caught by these tests.
Caught more issues introduced (I'm pretty sure) by #5:
[:div.foo {:class "bar"} "baz"]
), it's now rendering twice, as "<div id="baq" id="bar" class="foo">baz</div>"
[:div [test-fragment-component "hello"]]
gets rendered as "<div><<>nn><p>hello</p><p>hello</p></<>nn></div>"
The latter might be due to the interaction between #5 and this PR since I think the fragment test existed prior to this PR.
Never mind, that second issue was caused by a typo I introduced during rebase.
So far, the only divergence that has a semantic difference is our handling of conflicts between attributes in the map and tag. I think we want to follow Reagent's handling, but I don't know what that is yet.