lambdaisland / hiccup

Enlive-backed Hiccup implementation (clj-only)
Mozilla Public License 2.0
28 stars 4 forks source link

Add tests borrowed from Hiccup's test suite and make small tweaks to match Hiccup/Reagent behavior. #4

Open alysbrooks opened 1 year ago

alysbrooks commented 1 year ago

So far, the only divergence that has a semantic difference is our handling of conflicts between attributes in the map and tag. I think we want to follow Reagent's handling, but I don't know what that is yet.

alysbrooks commented 1 year ago

Based on looking into it further, MPL and EPL are very similar and as far as I can tell, can be combined freely.

alysbrooks commented 1 year ago

Latest version of Reagent's test suite: https://github.com/reagent-project/reagent/blob/master/src/reagent/impl/template.cljs. While I'm just integrating Hiccup tests for now, I'm trying to avoid introducing any incompatibilities.

alysbrooks commented 1 year ago

I think we can merge this after #5.

alysbrooks commented 11 months ago

I believe that #7 would have been caught by these tests.

alysbrooks commented 11 months ago

Caught more issues introduced (I'm pretty sure) by #5:

The latter might be due to the interaction between #5 and this PR since I think the fragment test existed prior to this PR.

Never mind, that second issue was caused by a typo I introduced during rebase.