search

lambdaisland / kaocha-cljs

ClojureScript support for Kaocha
Eclipse Public License 1.0
40 stars 10 forks source link

ClojureScript incompatible with tools.reader 1.3.1/1.3.2 #13

Open plexus opened 5 years ago

plexus commented 5 years ago

This is strictly an upstream issue, but posting it here since people might run into it and come looking for a solution.

https://clojure.atlassian.net/browse/CLJS-3097

Long story short: tools.reader changed the two-arity version of read+string to be in line with read+string in clojure.core

;; before
(read+string reader opts)

;; now
(read+string opts reader)

And this is used by the clojurescript prepl, which we rely on. So for the time being you have to stick to tools.reader 1.3.0.

alysbrooks commented 1 year ago

Looks like this was fixed shortly after. I haven't yet double-checked it by running kaocha-cljs with tools.reader 1.3.3 (or whatever succeeded 1.3.2) yet.

alysbrooks commented 1 year ago

This is a bug (or an incompatibility I think we'd prefer not to have), so it makes sense to leave this open as an extant issue. If we decide to stick with tools.reader 1.3.0, documenting it in a more permanent place than this issue is necessary.