search

lambdaisland / kaocha-cljs

ClojureScript support for Kaocha
Eclipse Public License 1.0
40 stars 10 forks source link

Introduce the queue-eval-loop #15

Closed plexus closed 5 years ago

plexus commented 5 years ago

We were jumping through quite some hoops to be able to use the ClojureScript PREPL programmitcally (oh the irony) because it expects a Reader for its input, which isn't that convenient when eval'ing forms that are coming from code, rather than from some character stream.

Instead replaced the prepl with a "queue-eval-loop", which does a queue/take! rather than a read+string. Seems to work well enough so far, let's hope it helps with reliability.

plexus commented 5 years ago

Ping @kommen. I'm really not sure this will fix the CI failures though, but at least it's one fewer possible culprit. I saw some similar errors when running the kaocha-cljs integrations locally, running them again went fine, which makes me think this is perhaps really a race condition in the ClojureScript node repl implementation.