search

lambdaisland / kaocha-cljs

ClojureScript support for Kaocha
Eclipse Public License 1.0
40 stars 10 forks source link

Pass compiler-options all the way through #17

Closed plexus closed 5 years ago

plexus commented 5 years ago

This one's a little embarrassing. We first create a repl-env, and pass the compiler options there, and then use that repl-env to create a prepl (actually a qepl but who's keeping track). My assumption was that the compiler options would be part of the repl-options, and that the options option to the prepl were prepl-specific options, but it seems actually both are merged and used as compiler options.

It's not clear to me if this is the correct way to use the options argument of the prepl, since it also contains things like :special-fns, but it does get the options to where they need to be.

Closes #16

plexus commented 5 years ago

@countgizmo can you try this out

lambdaisland/kaocha-cljs {:git/url "https://github.com/lambdaisland/kaocha-cljs"
                          :sha "1a3e1b07dbf72b2b01495a6c04fb4c6eb708dd30"}}

thanks

countgizmo commented 5 years ago

@plexus Trying...

countgizmo commented 5 years ago

@plexus It works! The compiled code is not using node_modules anymore - means the correct options are passed. Thank you!