search

lambdaisland / kaocha-cljs

ClojureScript support for Kaocha
Eclipse Public License 1.0
40 stars 10 forks source link

Remove references to now non-existent var in humane-print #45

Closed wit-0-bit closed 2 years ago

wit-0-bit commented 2 years ago

The Problem

When running inside docker, warnings about an undeclared var are displayed:

Screen Shot 2022-02-25 at 4 12 10 PM

I don't know why it seems to only be happening in docker and it does not seem to be breaking anything, but the warnings seem to have a point. The var humane-print/*sb* was replaced by a private var sb in the 0.10.0 release of humane-test-output: https://github.com/pjstadig/humane-test-output/commit/f01d7eec9d0ebf774a2956d8322556fcb8253c03

The Fix

Remove all references to humane-print/*sb*

Given that new var, humane-print/sb, is now private, it probably shouldn't be accessed. Additionally, since humane-print/clean and humane-print/with-pretty-writer are the only functions that references that var now and this uses neither, this change should not effect kaocha-cljs (except for the warnings).

plexus commented 2 years ago

Thanks a lot! Released in

[com.lambdaisland/kaocha-cljs "1.2.123"]
{com.lambdaisland/kaocha-cljs {:mvn/version "1.2.123"}}