Adds type annotations so that reflection warnings are prevented.

lambdaisland / kaocha-cucumber

Cucumber support for Kaocha

Eclipse Public License 1.0

38 stars 11 forks source link

Adds type annotations so that reflection warnings are prevented. #4

Closed mapidentity closed 4 years ago

mapidentity commented 4 years ago

See issue https://github.com/lambdaisland/kaocha-cucumber/issues/3

When code under test contains (set! *warn-on-reflection* true) the output contains reflection warnings from the kaocha-cucumber namespace. This PR adds type annotations so these warnings are prevented.

Feedback is greatly appreciated.

plexus commented 4 years ago

Thanks!

plexus commented 4 years ago

Clojure 1.10.1
user=> (require 'lambdaisland.cucumber.gherkin)
Syntax error (NoSuchFieldException) compiling . at (lambdaisland/cucumber/jvm.clj:156:34).
of

Seems List/of is problematic.

plexus commented 4 years ago

Found a fix, releasing as kaocha-cucumber "0.0-53". Thanks for the patch!

alysbrooks commented 1 year ago

Released in v0.1.84

[com.lambdaisland/kaocha-cucumber "0.1.84"]                 ;; deps.edn
{com.lambdaisland/kaocha-cucumber {:mvn/version "0.1.84"}}  ;; project.clj