lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/1.0.861/doc/1-introduction
Eclipse Public License 1.0
796 stars 82 forks source link

Exit codes are being reused #300

Open plexus opened 2 years ago

plexus commented 2 years ago

We have two places where we throw an early-exit with exit code 252. We should never do this, an exit code should unambiguously at the code that caused it.

alysbrooks commented 2 years ago

Looks like there's duplicates of 254, too.

Here's what I found with a quick-and-dirty ripgrep search:

src/kaocha/api.clj:84:     (throw+ {:kaocha/early-exit 254}))))
src/kaocha/plugin.clj:48:      (output/error-and-throw {:kaocha/early-exit 254} nil
src/kaocha/plugin.clj:56:        {:kaocha/early-exit 254} nil
src/kaocha/plugin.clj:68:        {:kaocha/early-exit 254} nil

src/kaocha/runner.clj:166:                                                             (throw+ {:kaocha/early-exit 252})))
src/kaocha/config.clj:31:         (throw+ {:kaocha/early-exit 252}))))
test/unit/kaocha/config_test.clj:60:    (is (= #:kaocha{:early-exit 252}
alysbrooks commented 1 year ago

Mostly addressed in #303. Docs just need to be wrapped up.