lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/1.0.861/doc/1-introduction
Eclipse Public License 1.0
796 stars 82 forks source link

Fix Windows crash when using `--watch` #378

Closed alysbrooks closed 1 year ago

alysbrooks commented 1 year ago

Not only does watching individual files not work with Beholder, when using Beholder on Windows, it actually crashes. This PR disables watching tests.edn when using Beholder as as temporary fix, as proposed by @colin-p-hill in #270 .

alysbrooks commented 1 year ago

This is a safe change, so I'm going to go ahead and merge.

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.47% // Head: 75.15% // Decreases project coverage by -0.32% :warning:

Coverage data is based on head (47a1510) compared to base (2747f2f). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #378 +/- ## ========================================== - Coverage 75.47% 75.15% -0.33% ========================================== Files 51 51 Lines 2732 2733 +1 Branches 255 254 -1 ========================================== - Hits 2062 2054 -8 - Misses 510 518 +8 - Partials 160 161 +1 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `55.92% <0.00%> (-1.12%)` | :arrow_down: | | unit | `69.32% <0.00%> (-0.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/lambdaisland/kaocha/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/kaocha/watch.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS93YXRjaC5jbGo=) | `75.58% <0.00%> (-2.72%)` | :arrow_down: | | [src/kaocha/api.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9hcGkuY2xq) | `71.00% <0.00%> (-2.00%)` | :arrow_down: | | [src/kaocha/testable.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90ZXN0YWJsZS5jbGo=) | `81.57% <0.00%> (-0.66%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.