search

lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/
Eclipse Public License 1.0
803 stars 84 forks source link

Fixup inconsistent aliases #389

Closed solar05 closed 1 year ago

solar05 commented 1 year ago

Fixes #329

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.54% // Head: 75.54% // No change to project coverage :thumbsup:

Coverage data is based on head (690c12d) compared to base (78f09a8). Patch coverage: 75.65% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #389 +/- ## ======================================= Coverage 75.54% 75.54% ======================================= Files 51 51 Lines 2772 2772 Branches 260 260 ======================================= Hits 2094 2094 Misses 519 519 Partials 159 159 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `56.63% <69.56%> (ø)` | | | unit | `69.73% <71.30%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/kaocha/type/clojure/test.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90eXBlL2Nsb2p1cmUvdGVzdC5jbGo=) | `90.90% <0.00%> (ø)` | | | [src/kaocha/type/ns.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90eXBlL25zLmNsag==) | `97.87% <0.00%> (ø)` | | | [src/kaocha/type/spec/test/ns.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90eXBlL3NwZWMvdGVzdC9ucy5jbGo=) | `92.10% <0.00%> (ø)` | | | [src/kaocha/result.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9yZXN1bHQuY2xq) | `89.18% <50.00%> (ø)` | | | [src/kaocha/type/spec/test/fdef.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90eXBlL3NwZWMvdGVzdC9mZGVmLmNsag==) | `68.85% <60.00%> (ø)` | | | [src/kaocha/type/spec/test/check.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90eXBlL3NwZWMvdGVzdC9jaGVjay5jbGo=) | `82.35% <62.50%> (ø)` | | | [src/kaocha/plugin/alpha/spec\_test\_check.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9wbHVnaW4vYWxwaGEvc3BlY190ZXN0X2NoZWNrLmNsag==) | `88.04% <66.66%> (ø)` | | | [src/kaocha/type/var.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS90eXBlL3Zhci5jbGo=) | `84.61% <75.00%> (ø)` | | | [src/kaocha/watch.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS93YXRjaC5jbGo=) | `71.67% <75.00%> (ø)` | | | [src/kaocha/specs.clj](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9zcGVjcy5jbGo=) | `83.56% <86.53%> (ø)` | | | ... and [3 more](https://codecov.io/gh/lambdaisland/kaocha/pull/389?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alysbrooks commented 1 year ago

Curious why you picked the single-letter alias for some and not others. I'm primarily wondering about s for spec. I would probably pick spec for that require, but if the majority of namespaces already use s (or you have another compelling reason), then I'm fine with it.

alysbrooks commented 1 year ago

FYI, the relevant part of our Clojure Style Guide:

Some namespaces that are very core to an application and used all over the place are better off having a shorter alias used consistently.

We should probably make this easier to find for contributors. :thinking:

alysbrooks commented 1 year ago

The changes look good overall. Thank you for the PR! (Sorry for not mentioning that in my initial comment.)

alysbrooks commented 1 year ago

Released in v1.78.1249

[lambdaisland/kaocha "1.78.1249"]                 ;; deps.edn
{lambdaisland/kaocha {:mvn/version "1.78.1249"}}  ;; project.clj