lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/1.0.861/doc/1-introduction
Eclipse Public License 1.0
792 stars 81 forks source link

Remove unnecessary requires #391

Closed alysbrooks closed 1 year ago

alysbrooks commented 1 year ago

Added some comments about some edge cases.

Unnecessary requires aren't a major issue, but there are advantages to cleaning them up. This PR silences some warnings from clj-kondo, makes the namespaces easier to understand, and may avoid some circular imports in the future.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +3.13 :tada:

Comparison is base (846248f) 71.42% compared to head (0b3c4b6) 74.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #391 +/- ## ========================================== + Coverage 71.42% 74.56% +3.13% ========================================== Files 52 52 Lines 2800 2799 -1 Branches 257 283 +26 ========================================== + Hits 2000 2087 +87 + Misses 628 522 -106 - Partials 172 190 +18 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `53.59% <ø> (+2.73%)` | :arrow_up: | | unit | `69.45% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/kaocha/api.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9hcGkuY2xq) | `74.74% <ø> (ø)` | | | [src/kaocha/assertions.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9hc3NlcnRpb25zLmNsag==) | `42.85% <ø> (ø)` | | | [src/kaocha/load.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9sb2FkLmNsag==) | `69.69% <ø> (ø)` | | | [src/kaocha/matcher\_combinators.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9tYXRjaGVyX2NvbWJpbmF0b3JzLmNsag==) | `25.00% <ø> (ø)` | | | [src/kaocha/monkey\_patch.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9tb25rZXlfcGF0Y2guY2xq) | `83.01% <ø> (ø)` | | | [src/kaocha/ns.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9ucy5jbGo=) | `100.00% <ø> (ø)` | | | [src/kaocha/plugin/capture\_output.cljc](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9wbHVnaW4vY2FwdHVyZV9vdXRwdXQuY2xqYw==) | `100.00% <ø> (+3.12%)` | :arrow_up: | | [src/kaocha/plugin/filter.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9wbHVnaW4vZmlsdGVyLmNsag==) | `87.50% <ø> (-0.90%)` | :arrow_down: | | [src/kaocha/repl.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9yZXBsLmNsag==) | `37.03% <ø> (ø)` | | | [src/kaocha/runner.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS9ydW5uZXIuY2xq) | `45.00% <ø> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/lambdaisland/kaocha/pull/391/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alysbrooks commented 1 year ago

This seems slightly more prone to breaking things not covered by tests, so I figure we should wait until #413 is merged.

alysbrooks commented 1 year ago

Released in v1.84.1335

[lambdaisland/kaocha "1.84.1335"]                 ;; deps.edn
{lambdaisland/kaocha {:mvn/version "1.84.1335"}}  ;; project.clj